docgen: recognize "unimplemented" as marker to ignore rules

[jseldess]

Various aspects of our SQL grammar are marked as "unimplemented". These unimplemented features/keywords/etc. should not be included in the generated SQL diagrams we use in our docs. Currently, we must edit diagrams.go to hide unimplemented syntax from the generated bnfs that are used to genereate our SQL diagrams. Instead, it would be great if "unimplemented" were treated like /* SKIP DOC */. This would be much more efficient in that all unimplemented features would be excluded from all generated bnfs without docs writers needed to tweak diagrams.go.

Example: #45442

Jira issue: CRDB-5153

[rdtr]

Hi,

I'm new to CRDB and looking for something to contribute, so I may be wrong but don't we handle "SKIP DOC" and "unimplemented" already here ?

Or somehow we want to apply "unimplemented" to skip each Item level in Expressions instead of skipping the whole Expression?

[jseldess]

@knz, can you chime in here?

[github-actions]

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

[jseldess]

This is still relevant.

[ravikanthdba]

Hi I'm new to Cockroach DB, and was looking to contribute to open source here, so I see this as "Closed", is this issue still open?

[knz]

it is still open.