New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: support COPY FROM ... WHERE .... #54580
Labels
A-tools-psycopg
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
docs-done
docs-known-limitation
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
T-sql-queries
SQL Queries Team
Comments
otan
added
the
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
label
Sep 18, 2020
otan
added this to Triage
in SQL Features (Deprecated - use SQL Experience board)
via automation
Sep 18, 2020
craig bot
pushed a commit
that referenced
this issue
Sep 18, 2020
54536: sql: add unimplemented errors for trigrams r=solongordon a=otan Resolves #51137 **sql: add unimplemented errors for index with operator classes** * Amend lexing to do lookahead for NULLS FIRST / NULLS LAST to avoid shift/reduce conflicts. * Amend index_params support to be Postgre-compatible. Doing a_exprs inside indexes now require surrounding braces. * Add operator_class argument to index_params. * Add unimplemented error for operator class support. Release note: None **builtins: add unimplemented notices around trigram builtins** Release note: None 54541: opt: build constraint for containment operator r=rytaft a=mgartner This commit builds a non-tight, non-null constraint for containment operators. This is valid because `NULL` cannot contain any elements. This fixes a minor issue with the statistics of partial inverted index scans. Tests for these scans have been added for in this commit. Release note: None 54558: opt: deduce not-null constraints for functions with non-nullable args r=rytaft a=rytaft Release justification: low risk, high benefit changes to existing functionality, bug fixes and low-risk updates to new functionality This commit enhances the constraint builder code so that it can deduce not-null constraints for any variable arguments to functions with non- nullable args. This is important for improving optimizer support for spatial functions, since many of these functions have non-nullable args and are used as filter predicates. Deducing not-null constraints for the arguments to these functions enables us to calculate more accurate statistics, and may unlock other optimizations. Release note (performance improvement): The optimizer can now deduce that certain variable arguments to functions must be non-null. This improves cardinality estimation for those variables and unlocks other types of optimizations. As a result, the optimizer may choose better query plans when a function is used as a filter predicate. 54579: parser: add unimplemented for GROUP BY {GROUPING SETS, ROLLUP, CUBE} r=solongordon a=otan Refs #51424 Refs #46280 Release note: None 54582: parser: add unimplemented error for COPY ... WHERE ... r=solongordon a=otan Refs #54580 Refs #51424 Release note: None Co-authored-by: Oliver Tan <otan@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>
solongordon
moved this from Triage
to Backlog
in SQL Features (Deprecated - use SQL Experience board)
Oct 13, 2020
@otan wondering why this was tagged bulk? separately, looks like it was implemented -- can we close if so? |
Import takes in copy clauses which need is why I tagged it |
Not sure if this was implemented, this still does not work..... psycopg/psycopg#78 |
blathers-crl
bot
added
the
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
label
Sep 1, 2021
rafiss
moved this from Longer term backlog
to Potentially for 22.2
in SQL Sessions - Deprecated
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-tools-psycopg
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
docs-done
docs-known-limitation
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
T-sql-queries
SQL Queries Team
PostgreSQL 12 introduced a COPY FROM ... WHERE .. clause: https://www.postgresql.org/docs/current/sql-copy.html
I imagine this has knock on effects for bulk-io / IMPORT PGCOPY.
Jira issue: CRDB-3739
Epic CRDB-18320
The text was updated successfully, but these errors were encountered: