Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: update SQL API transaction contention query to not select from crdb_internal.ranges #94445

Closed
ericharmeling opened this issue Dec 29, 2022 · 0 comments · Fixed by #94803
Closed

ui: update SQL API transaction contention query to not select from crdb_internal.ranges #94445

ericharmeling opened this issue Dec 29, 2022 · 0 comments · Fixed by #94803
Assignees
@ericharmeling
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@ericharmeling
Copy link
Contributor

ericharmeling commented Dec 29, 2022 •
edited

One of the SQL API queries for transaction contention insights joins on crdb_internal.ranges. We should update this query to not select from crdb_internal.ranges and then backport this change to 22.2, for the following reasons:

  1. Transaction insight details are now broken on master.
    As of sql: better SHOW RANGES and changes to crdb_internal.ranges{,_no_leases} #93644, the problematic query selects columns that no longer exist in crdb_internal.ranges (in specific, database_name). As a result, the transaction insight details page on the console will hang/return an error for all cluster types (self-hosted, dedicated, serverless, etc).
  2. 22.2 Serverless CC console transaction insight details will not work.
    sql: support crdb_internal.ranges{_no_leases} for secondary tenants #92131 was not backported to 22.2. So querying crdb_internal.ranges from a 22.2 tenant cluster won't work. This is a blocker for https://github.com/cockroachlabs/managed-service/pull/10854.

This issue only affects transaction insight details.

Jira issue: CRDB-22892
@ericharmeling ericharmeling added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-observability labels Dec 29, 2022
@blathers-crl blathers-crl bot added this to Triage in Cluster Observability Dec 29, 2022
@ericharmeling ericharmeling changed the title ui: update SQL API transaction contention query to crdb_internal.ranges ui: update SQL API transaction contention query to not select from crdb_internal.ranges Jan 4, 2023
@j82w j82w mentioned this issue Jan 4, 2023
Closed
@ericharmeling ericharmeling self-assigned this Jan 5, 2023
@ericharmeling ericharmeling moved this from Triage to Active Issues in Cluster Observability Jan 5, 2023
@ericharmeling ericharmeling mentioned this issue Jan 5, 2023
Merged
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Jan 5, 2023
@ericharmeling
ui: update transaction insight details SQL query to no select from cr…
25f0f4c 
…db_internal.ranges

Fixes cockroachdb#94445.

This commit updates the SQL-over-HTTP query executed on behalf of the transaction
insight details page to not select from the crdb_internal.ranges table, and instead
select from other internal tables.

Release note: None
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Jan 6, 2023
@ericharmeling
ui: update transaction insight details SQL query to not select from c…
995ee7d 
…rdb_internal.ranges

Fixes cockroachdb#94445.

This commit updates the SQL-over-HTTP query executed on behalf of the transaction
insight details page to not select from the crdb_internal.ranges table, and instead
select from other internal tables.

Release note: None
@ericharmeling ericharmeling mentioned this issue Jan 6, 2023
Closed
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Jan 10, 2023
@ericharmeling
ui: update transaction insight details SQL query to not select from c…
b1a01a7 
…rdb_internal.ranges

Fixes cockroachdb#94445.

This commit updates the SQL-over-HTTP query executed on behalf of the transaction
insight details page to not select from the crdb_internal.ranges table, and instead
select from other internal tables.

Release note: None
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Jan 11, 2023
@ericharmeling
ui: update transaction insight details SQL query to not select from c…
40fcc96 
…rdb_internal.ranges

Fixes cockroachdb#94445.

This commit updates the SQL-over-HTTP query executed on behalf of the transaction
insight details page to not select from the crdb_internal.ranges table, and instead
select from other internal tables.

Release note: None
Cluster Observability automation moved this from Active Issues to Done Jan 11, 2023
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Jan 13, 2023
@ericharmeling
ui: update transaction insight details SQL query to not select from c…
8b8d772 
…rdb_internal.ranges

Fixes cockroachdb#94445.

This commit updates the SQL-over-HTTP query executed on behalf of the transaction
insight details page to not select from the crdb_internal.ranges table, and instead
select from other internal tables.

Release note: None
@ericharmeling ericharmeling mentioned this issue Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericharmeling ericharmeling

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
1 participant
@ericharmeling