Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Renumber proposer-evaluated KV RaftCommand fields #10724

Merged
merged 1 commit into from Nov 16, 2016

Conversation

bdarnell
Copy link
Member

@bdarnell bdarnell commented Nov 16, 2016

Older versions were writing non-nil but empty values into these fields,
leading to problems on upgrade. Since there is no non-experimental use
of these fields yet, renumber them to discard all old data.

Fixes #10723


This change is Reviewable

Older versions were writing non-nil but empty values into these fields,
leading to problems on upgrade. Since there is no non-experimental use
of these fields yet, renumber them to discard all old data.

Fixes cockroachdb#10723
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mberhault
Copy link
Contributor

I know we generally shy away from this, but I'll merge this for Ben and see if it fixes cyan.

@mberhault mberhault merged commit 96a591f into cockroachdb:master Nov 16, 2016
@petermattis
Copy link
Collaborator

I think Cyan will have to be wiped. You'll have to ask Ben to be sure.

@mberhault
Copy link
Contributor

He said the following in slack/production: merging that and deploying it to cyan should fix things (with no need to wipe the cluster) so I'll give a plain restart a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants