c-deps: update to protobuf 3.3.0 #15522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Seems scary to be updating a dep at this point. Can you expand on the justification for doing so? If this is to get rid of compiler warnings, I'd be more comfortable doing so after the 1.0 release branch is cut. Review status: 0 of 17 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Agreed; set the milestone to 1.1. No specific justification here, just tidying up. |
|
@petermattis is this good to go, now? |
|
Review status: 0 of 17 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.