*: remove stale skips of test tenant randomization #156510
Merged
+48
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips. Release note: None
yuzefovich
requested review from
alyshanjahani-crl and
kev-cao
and removed request for
a team,
alyshanjahani-crl and
kev-cao
|
This change is |
stevendanna
approved these changes
Oct 30, 2025
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
156492: go.mod: bump Pebble to e8d7ecb38559 r=annrpom a=jbowens Changes: * [`e8d7ecb3`](cockroachdb/pebble@e8d7ecb3) db: tolerate unknown options * [`75afc702`](cockroachdb/pebble@75afc702) vfs: log GetDiskUsage calls in loggingFS * [`459c8ae8`](cockroachdb/pebble@459c8ae8) db: scan and filter WALs during recovery * [`91dfeada`](cockroachdb/pebble@91dfeada) db: move locking of WAL recovery directories * [`15d065ba`](cockroachdb/pebble@15d065ba) db: fix RangeDeletionBytesEstimate * [`c26a7b21`](cockroachdb/pebble@c26a7b21) db: add RangeDeletionBytesEstimate blob file test * [`580eb1a8`](cockroachdb/pebble@580eb1a8) db,valsep: move valsep tests to appropriate pkg Release note: none. Epic: none. 156510: *: remove stale skips of test tenant randomization r=yuzefovich a=yuzefovich I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips. Epic: CRDB-48945 Release note: None Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
156486: spanconfig: version gate meta1/meta2 split point in spanconfig r=iskettaneh a=iskettaneh This commit adds a version gate around the spanconfig split point between meta1 and meta2 to avoid scenarios during a rolling upgrade where the job switches back and forth between a v25.4 and a v26.1 versions, which could result in the split point be created a removed multiple times. This was originally done in #119594. Fixes: #119421 Release note: None 156505: scbuild: update stub method for isV261Active r=rafiss a=rafiss The version has been created, so we can fix this function now. Epic: None Release note: None 156510: *: remove stale skips of test tenant randomization r=yuzefovich a=yuzefovich I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips. Epic: CRDB-48945 Release note: None 156565: logictest: reduce data set in cursor test r=yuzefovich a=yuzefovich We've seen a few failures on `cursor` logic test under race which seems to be due to node overload / timeout. My hypothesis is it's due to metamorphic randomization, and I found one spot where we use 10k rows in the table, but I don't think we need this much. This commit reduces the row count to just 10 in hopes of eliminating the flake under race. Fixes: #155609. Release note: None Co-authored-by: iskettaneh <173953022+iskettaneh@users.noreply.github.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
156505: scbuild: update stub method for isV261Active r=rafiss a=rafiss The version has been created, so we can fix this function now. Epic: None Release note: None 156510: *: remove stale skips of test tenant randomization r=yuzefovich a=yuzefovich I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips. Epic: CRDB-48945 Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
|
Build failed (retrying...): |
jeffswenson
added a commit
to jeffswenson/cockroach
that referenced
this pull request
Nov 1, 2025
The legacy sql writer and the kv writer both have this logic for stripping tenant prefixes before decoding the key. This was uncovered because cockroachdb#156510 enabled metamorphic multi-tenancy for the LDR tests. Release note: none Fixes: cockroachdb#156640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips.
Epic: CRDB-48945
Release note: None