From 32e36f6f1d02816bb8a16b4bd4e3e5fc790ee02a Mon Sep 17 00:00:00 2001 From: Jeff Swenson Date: Fri, 31 Oct 2025 12:36:50 -0400 Subject: [PATCH] logical: remove crud writer from metamorphic tests The crud writer has an unknown issue in multi-tenant environments. Release note: none Informs: #156640 --- pkg/sql/sqlclustersettings/clustersettings.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/sql/sqlclustersettings/clustersettings.go b/pkg/sql/sqlclustersettings/clustersettings.go index 1ec5db45518f..6a2374e87cea 100644 --- a/pkg/sql/sqlclustersettings/clustersettings.go +++ b/pkg/sql/sqlclustersettings/clustersettings.go @@ -145,7 +145,7 @@ var LDRImmediateModeWriter = settings.RegisterStringSetting( "logical_replication.consumer.immediate_mode_writer", "the writer to use when in immediate mode", // TODO(jeffswenson): make the crud writer the default - metamorphic.ConstantWithTestChoice("logical_replication.consumer.immediate_mode_writer", string(LDRWriterTypeLegacyKV), string(LDRWriterTypeCRUD), string(LDRWriterTypeSQL)), + metamorphic.ConstantWithTestChoice("logical_replication.consumer.immediate_mode_writer", string(LDRWriterTypeLegacyKV), string(LDRWriterTypeSQL)), settings.WithValidateString(func(sv *settings.Values, val string) error { if val != string(LDRWriterTypeSQL) && val != string(LDRWriterTypeLegacyKV) && val != string(LDRWriterTypeCRUD) { return errors.Newf("immediate mode writer must be either 'sql', 'legacy-kv', or 'crud', got '%s'", val)