Skip to content

Conversation

@yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Nov 5, 2025

Backport 1/1 commits from #156823 on behalf of @yuzefovich.


We've seen a couple of failures where we didn't parallelize lookup joins when we expected to. This flake should've been fixed in 41d129a yet it still failed twice after that. I don't have any explanation for the flake, so let's just add a retry directive in one spot.

Fixes: #155750.
Release note: None


Release justification: test-only change.

We've seen a couple of failures where we didn't parallelize lookup joins
when we expected to. This flake should've been fixed in
41d129a yet it still failed twice after
that. I don't have any explanation for the flake, so let's just add
a retry directive in one spot.

Release note: None
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 5, 2025
@blathers-crl blathers-crl bot requested a review from michae2 November 5, 2025 19:49
@blathers-crl
Copy link

blathers-crl bot commented Nov 5, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Nov 5, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@michae2 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Nov 5, 2025
@yuzefovich yuzefovich merged commit 19d91ff into cockroachdb:release-25.4 Nov 5, 2025
15 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-25.4-156823 branch November 5, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team target-release-25.4.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants