From 08ce8f9352df22f48b415250f3b62c089c8a8a52 Mon Sep 17 00:00:00 2001 From: Andy Yang Date: Wed, 5 Nov 2025 21:51:59 -0500 Subject: [PATCH] roachtest: deflake cdc/ledger This patch deflakes `cdc/ledger` by increasing the target steady latency from 1 minute to 3 minutes. It also eliminates a weird quirk where the latency verifier expects the latency to be less than half of the target latency before it'll be considered steady, which led to weird logs and added unnecessary complexity. Release note: None --- pkg/cmd/roachtest/tests/cdc.go | 2 +- pkg/cmd/roachtest/tests/latency_verifier.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/roachtest/tests/cdc.go b/pkg/cmd/roachtest/tests/cdc.go index cbcd36faf6f9..4ad3c27cea74 100644 --- a/pkg/cmd/roachtest/tests/cdc.go +++ b/pkg/cmd/roachtest/tests/cdc.go @@ -2574,7 +2574,7 @@ CONFIGURE ZONE USING }) ct.runFeedLatencyVerifier(feed, latencyTargets{ initialScanLatency: 10 * time.Minute, - steadyLatency: time.Minute, + steadyLatency: 3 * time.Minute, }) ct.waitForWorkload() }, diff --git a/pkg/cmd/roachtest/tests/latency_verifier.go b/pkg/cmd/roachtest/tests/latency_verifier.go index eae18c224316..f14da60f847b 100644 --- a/pkg/cmd/roachtest/tests/latency_verifier.go +++ b/pkg/cmd/roachtest/tests/latency_verifier.go @@ -116,7 +116,7 @@ func (lv *latencyVerifier) noteHighwater(highwaterTime time.Time) { return } - if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency/2 { + if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency { lv.latencyBecameSteady = true } if !lv.latencyBecameSteady {