From c98bc06194f70a482fd1a3a6d7cc49c28628a9e2 Mon Sep 17 00:00:00 2001 From: Andy Yang Date: Thu, 6 Nov 2025 02:51:59 +0000 Subject: [PATCH] roachtest: deflake cdc/ledger This patch deflakes `cdc/ledger` by increasing the target steady latency from 1 minute to 3 minutes. It also eliminates a weird quirk where the latency verifier expects the latency to be less than half of the target latency before it'll be considered steady, which led to weird logs and added unnecessary complexity. Release note: None --- pkg/cmd/roachtest/tests/cdc.go | 2 +- pkg/cmd/roachtest/tests/latency_verifier.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/roachtest/tests/cdc.go b/pkg/cmd/roachtest/tests/cdc.go index 091218c0b83e..b73ca4899547 100644 --- a/pkg/cmd/roachtest/tests/cdc.go +++ b/pkg/cmd/roachtest/tests/cdc.go @@ -2202,7 +2202,7 @@ func registerCDC(r registry.Registry) { }) ct.runFeedLatencyVerifier(feed, latencyTargets{ initialScanLatency: 10 * time.Minute, - steadyLatency: time.Minute, + steadyLatency: 3 * time.Minute, }) ct.waitForWorkload() }, diff --git a/pkg/cmd/roachtest/tests/latency_verifier.go b/pkg/cmd/roachtest/tests/latency_verifier.go index b0ebaee774f1..ae7fa6d429a1 100644 --- a/pkg/cmd/roachtest/tests/latency_verifier.go +++ b/pkg/cmd/roachtest/tests/latency_verifier.go @@ -114,7 +114,7 @@ func (lv *latencyVerifier) noteHighwater(highwaterTime time.Time) { return } - if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency/2 { + if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency { lv.latencyBecameSteady = true } if !lv.latencyBecameSteady {