settings: min_wal_sync_interval defaults to 0ms #17601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, the default min_wal_sync_interval was 1ms, which provided modest performance gains for certain workloads but severe penalties for others. Now, the default is 0ms.
jordanlewis
force-pushed
the
min_wal_sync_zero
branch
from
2894aad
to
2b98a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default min_wal_sync_interval was 1ms, which provided
modest performance gains for certain workloads but severe penalties for
others.
Now, the default is 0ms.
This produces a ~450% speed boost against
kv --read-percent=0 --cycle-length 1and a ~30% speed boost effect againsttpcc.Closes #17557.