sql: fix some spelling errors #20727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Please make sure that the changes to |
|
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
jordanlewis
approved these changes
Dec 14, 2017
| "FLOAT4": ColumnType_REAL, | ||
| "REAL": ColumnType_REAL, | ||
| "FLOAT8": ColumnType_DOUBLE_PRECISION, | ||
| "DOUBLE PRECISION": ColumnType_DOUBLE_PRECISION, |
There was a problem hiding this comment.
Fairly sure this is fixing a real but minor bug - I think without this change users wouldn't be able to specify a DOUBLE PRECISION type with a precision type omdifier. Or something like that.
There was a problem hiding this comment.
Looks like there's a test failure so you might be right. I'll update the release notes if this is the case.
There was a problem hiding this comment.
Yep, was a minor bug, added the release note.
|
Comments from Reviewable |
Release note: (sql) A small spelling bug made it such that a `DOUBLE PRECISION` specified type would erroneously display as a float. Interally these are the same type, so this was just an bug on showing the correct type alias when calling `SHOW COLUMNS`.
BramGruneir
force-pushed
the
precision
branch
from
044f156
to
8d13170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None