sqlccl: remove external storage dependency on RESTORE cleanup #21559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If RESTORE failed and attempted to delete the data it had added, it would fail to do so if the underlying external data had been deleted. This would cause the job to forever be in a state where the job could neither be canceled or failed because those methods would never succeed, causing the job to loop forever in the registry. Remove the dependency on the external storage by storing the sql descriptors in the job details. Release note (enterprise change): make RESTORE cleanup resilient to external storage failure or removal Fixes #20261
|
This change is |
benesch
approved these changes
Jan 18, 2018
|
I don't think we need to worry about protobuf version skews here (i.e., running restores on different cluster versions) because the cleanup code was added in the 2.0 branch. 1.1 is still affected by this bug, and there's not really a handy way to repair it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RESTORE failed and attempted to delete the data it had added,
it would fail to do so if the underlying external data had been
deleted. This would cause the job to forever be in a state where the
job could neither be canceled or failed because those methods would
never succeed, causing the job to loop forever in the registry.
Remove the dependency on the external storage by storing the sql
descriptors in the job details.
Release note (enterprise change): make RESTORE cleanup resilient to
external storage failure or removal
Fixes #20261