backupccl: check revision start time #22659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Record the revision start time, which may not be the same as the start time, namely in full backups where start time is 0 but revision history obviously can only be captured since the GC threshold. The backup records the latest safe time and then restore checks that requested times are after that. Fixes cockroachdb#19455. Release note (enterprise change): Check that backup actually contains requested restore time.
|
Note that this is stricter than it technically needs to be -- we could store per-span times and then just look at those spans needed when we restore. Probably only really makes a big difference though in the case where your tables have greatly different retention policies, and you'd still have the option of backing them up separately too or taking incremental more often, so I'm not sure it is worth the extra complexity yet. |
|
I think probably not, since there is the workaround of just doing 2 separate backups for those different tables. At some point, we could do some really user friendly stuff here, but probably not worth the time right now. |
maddyblue
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record the revision start time, which may not be the same as the start
time, namely in full backups where start time is 0 but revision history
obviously can only be captured since the GC threshold. The backup
records the latest safe time and then restore checks that requested
times are after that.
Release note (enterprise change): Check that backup actually contains requested restore time.