cherrypick-2.0.1: sql: fix crash in physicalProps #24517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `addEquivalency` method wasn't properly handling the case when one of the columns is constant. This causes the other column to become constant, and thus it needs to be removed from all weak keys. Adding a test designed to catch the general class of bugs where a mutation causes the invariants to be invalidated; verified that it catches the problem. Fixes cockroachdb#24500. Release note (bug fix): Fixed a crash caused by a WHERE condition that requires a column to equal a specific value and at the same time equal another column.
|
This change is |
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
added a commit
that referenced
this pull request
Apr 5, 2018
24517: cherrypick-2.0.1: sql: fix crash in physicalProps r=RaduBerinde a=RaduBerinde The `addEquivalency` method wasn't properly handling the case when one of the columns is constant. This causes the other column to become constant, and thus it needs to be removed from all weak keys. Adding a test designed to catch the general class of bugs where a mutation causes the invariants to be invalidated; verified that it catches the problem. Fixes #24500. Release note (bug fix): Fixed a crash caused by a WHERE condition that requires a column to equal a specific value and at the same time equal another column. Cherrypick of PR #24506. CC @cockroachdb/release
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addEquivalencymethod wasn't properly handling the case when oneof the columns is constant. This causes the other column to become
constant, and thus it needs to be removed from all weak keys.
Adding a test designed to catch the general class of bugs where a
mutation causes the invariants to be invalidated; verified that it
catches the problem.
Fixes #24500.
Release note (bug fix): Fixed a crash caused by a WHERE condition that
requires a column to equal a specific value and at the same time equal
another column.
Cherrypick of PR #24506. CC @cockroachdb/release