Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-2.0: compactor: don't block during suggestion in Start() #24831

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@tbg
Copy link
Member

commented Apr 16, 2018

Backport 1/1 commits from #24808.

/cc @cockroachdb/release


When we Start the Compactor, it may already have received
Suggestions, deadlocking the previously blocking write to a full
channel.

Release note (bug fix): Fixed a scenario in which a node could deadlock
while starting up.

compactor: don't block during suggestion in Start()
When we `Start` the `Compactor`, it may already have received
`Suggestion`s, deadlocking the previously blocking write to a full
channel.

Release note (bug fix): Fixed a scenario in which a node could deadlock
while starting up.

@tbg tbg requested a review from bdarnell Apr 16, 2018

@tbg tbg requested a review from cockroachdb/core-prs as a code owner Apr 16, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Apr 16, 2018

This change is Reviewable

@tbg

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2018

bors r=bdarnell

craig bot pushed a commit that referenced this pull request Apr 17, 2018

Merge #24831
24831: backport-2.0: compactor: don't block during suggestion in Start() r=bdarnell a=tschottdorf

Backport 1/1 commits from #24808.

/cc @cockroachdb/release

---

When we `Start` the `Compactor`, it may already have received
`Suggestion`s, deadlocking the previously blocking write to a full
channel.

Release note (bug fix): Fixed a scenario in which a node could deadlock
while starting up.


Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Apr 17, 2018

Build succeeded

@craig craig bot merged commit c4b5e85 into cockroachdb:release-2.0 Apr 17, 2018

4 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
code-review/reviewable Review complete: 0 of 0 LGTMs obtained
Details
license/cla Contributor License Agreement is signed.
Details

@tbg tbg deleted the tbg:backport2.0-24808 branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.