/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: cleanup reference to ExecCfg #25107

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Reviewers

@cockroachdb/core-prs core-prs

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@cockroachdb/admin-ui-prs admin-ui-prs

Assignees

@RaduBerinde RaduBerinde

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andreimatei @cockroach-teamcity @RaduBerinde
@andreimatei
Member

andreimatei commented Apr 26, 2018

A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None

@andreimatei andreimatei assigned RaduBerinde Apr 26, 2018

@andreimatei andreimatei requested review from cockroachdb/sql-execution-prs as code owners Apr 26, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Apr 26, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Apr 26, 2018

This change is Reviewable
@RaduBerinde

This comment has been minimized.

Show comment
Hide comment
@RaduBerinde

RaduBerinde Apr 26, 2018

Member

LGTM, thanks. Sorry for littering 😊
Member

RaduBerinde commented Apr 26, 2018

LGTM, thanks. Sorry for littering 😊
@andreimatei

This comment has been minimized.

Show comment
Hide comment
@andreimatei

andreimatei Apr 26, 2018

Member
Member

andreimatei commented Apr 26, 2018

craig bot pushed a commit that referenced this pull request Apr 26, 2018

craig[bot] @a-robinson
@mjibson @andreimatei
Merge #25072 #25083 #25086 #25107 
25072: storage/ui: Expose range's maxBytes field to help debug split issues r=a-robinson a=a-robinson

Release note: None

This is a pretty natural fit for going in the `RangeInfo`, and would be nice to see in issues like #24966

25083: server: Improve locking in metric/status recorder r=a-robinson a=a-robinson

When a store slows down, the WriteStatusSummary call can block for very
long periods of time because it calls down into Store.Descriptor, which
walks over all of its replicas. This avoids blocking important endpoints
like the one for Prometheus metrics (/_status/vars).

Inspired by the major slowdown on omega after dropping a table that was
many hundreds of gigabytes, and seeing alerts that Prometheus thought
the server was down even though it was actually still running.

Release note (admin ui change): Improve responsiveness of Prometheus
metrics endpoint on very overloaded nodes.

25086: cmd/docgen: simplify and correct various alter/drop statements r=mjibson a=mjibson

This should make the maintenance of these easier in the future.

Release note: None

25107: sql: cleanup reference to ExecCfg r=andreimatei a=andreimatei

A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None

Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
6ea716b
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Apr 26, 2018

Build failed (retrying...)

craig bot commented Apr 26, 2018

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Apr 26, 2018

craig[bot] @a-robinson @andreimatei
Merge #25072 #25107 
25072: storage/ui: Expose range's maxBytes field to help debug split issues r=a-robinson a=a-robinson

Release note: None

This is a pretty natural fit for going in the `RangeInfo`, and would be nice to see in issues like #24966

25107: sql: cleanup reference to ExecCfg r=andreimatei a=andreimatei

A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None

Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
cc51181
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Apr 26, 2018

Build failed (retrying...)

craig bot commented Apr 26, 2018

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Apr 26, 2018

craig[bot] @dt @andreimatei
Merge #25075 #25107 
25075: importccl: EXPORT CSV r=dt a=dt

This is a re-opening of #24755 after it was closed by a mistaken branch deletion, which unfortunately also prevents re-opening in place.

This adds a DistSQL processor that writes whatever it is given as CSV files to a specified storage location.

This processor can be appended as a sink for arbitrary SELECT queries.

The primary intended use-case is dumping tables as CSV for bulk-export, but it can also be used on any SELECT query, so it could also be used in report generation or other workflows.

Release note (enterprise change): prototype support for EXPORT CSV.


25107: sql: cleanup reference to ExecCfg r=andreimatei a=andreimatei

A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None

Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
5c6299f
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Apr 26, 2018

Build failed (retrying...)

craig bot commented Apr 26, 2018

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Apr 26, 2018

craig[bot] @andreimatei
Merge #25107 
25107: sql: cleanup reference to ExecCfg r=andreimatei a=andreimatei

A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
3eecaae
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Apr 26, 2018

Build failed

craig bot commented Apr 26, 2018

Build failed
@andreimatei
sql: cleanup reference to ExecCfg 
A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None
Loading status checks…
dd77798

@andreimatei andreimatei requested review from cockroachdb/admin-ui-prs as code owners Apr 27, 2018

@andreimatei

This comment has been minimized.

Show comment
Hide comment
@andreimatei

andreimatei Apr 27, 2018

Member

my bad

bors r+

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
Member

andreimatei commented Apr 27, 2018

my bad

bors r+

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

craig bot pushed a commit that referenced this pull request Apr 27, 2018

craig[bot] @andreimatei
Merge #25107 
25107: sql: cleanup reference to ExecCfg r=andreimatei a=andreimatei

A test was using an InternalExecutor to get an ExecutorConfig, but
there's a better way. Also the old way is about to break.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
9b66b51
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Apr 27, 2018

Build succeeded

craig bot commented Apr 27, 2018

Build succeeded

@craig craig bot merged commit dd77798 into cockroachdb:master Apr 27, 2018
4 checks passed

4 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
code-review/reviewable Review complete: 0 of 0 LGTMs obtained
Details
license/cla Contributor License Agreement is signed.
Details

@andreimatei andreimatei deleted the andreimatei:sql-join-test branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment