/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ensure TeamCity captures scoped logs in test[race] #25239

Merged
merged 1 commit into from May 11, 2018

Conversation

Reviewers

@jordanlewis jordanlewis

@cockroachdb/build-prs build-prs

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@benesch @cockroach-teamcity @jordanlewis
@benesch
Member

benesch commented May 2, 2018

log.Scope puts logs in a temporary directory, but we want those logs to
be available in TeamCity. Set TMPDIR to "artifacts", which TeamCity is
configured to look in. (This is how the acceptance tests currently
work.)

Fix #20245.

Release note: None
@benesch
build: ensure TeamCity captures scoped logs in test[race] 
log.Scope puts logs in a temporary directory, but we want those logs to
be available in TeamCity. Set TMPDIR to "artifacts", which TeamCity is
configured to look in. (This is how the acceptance tests currently
work.)

Fix #20245.

Release note: None
Verified
This commit was signed with a verified signature.
@benesch benesch Nikhil Benesch
GPG key ID: C5779C9897F0FCCB Learn about signing commits
Loading status checks…
4147f96

@benesch benesch requested a review from jordanlewis May 2, 2018

@benesch benesch requested a review from cockroachdb/build-prs as a code owner May 2, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity May 2, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented May 2, 2018

This change is Reviewable

@benesch benesch added the fixitday label May 3, 2018

@jordanlewis

jordanlewis approved these changes May 7, 2018
View changes

LGTM but I'm slightly worried this will be a lot of logs. Let's keep an eye out.

@benesch

This comment has been minimized.

Show comment
Hide comment
@benesch

benesch May 11, 2018

Member

TFTR! It only keeps logs from failed tests—and I think there are only like three tests outside of pkg/acceptance that call log.Scope—so I'm not too worried.

bors r=jordanlewis
Member

benesch commented May 11, 2018

TFTR! It only keeps logs from failed tests—and I think there are only like three tests outside of pkg/acceptance that call log.Scope—so I'm not too worried.

bors r=jordanlewis

craig bot pushed a commit that referenced this pull request May 11, 2018

craig[bot] @benesch
Merge #25239 
25239: build: ensure TeamCity captures scoped logs in test[race] r=jordanlewis a=benesch

log.Scope puts logs in a temporary directory, but we want those logs to
be available in TeamCity. Set TMPDIR to "artifacts", which TeamCity is
configured to look in. (This is how the acceptance tests currently
work.)

Fix #20245.

Release note: None

Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Loading status checks…
2915ee7
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot May 11, 2018

Build succeeded

craig bot commented May 11, 2018

Build succeeded

@craig craig bot merged commit 4147f96 into cockroachdb:master May 11, 2018
4 checks passed

4 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
code-review/reviewable Review complete: 0 of 0 LGTMs obtained
Details
license/cla Contributor License Agreement is signed.
Details

@benesch benesch deleted the benesch:teamcity-artifacts branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment