/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to training, clarify "Need Help" section #27813

Open
wants to merge 2 commits into
base: master
from
+18 −8

Conversation

Reviewers

@jseldess jseldess

@nstewart nstewart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tim-o @cockroach-teamcity @CLAassistant @jseldess
@tim-o
Contributor

tim-o commented Jul 20, 2018

Made "Need help" consistent with the github template PR, and added references to the 2.0.4 training. @jseldess - are you OK with us pushing folks to the material?

If there's anyone else who should review a change to the readme, let me know.
@tim-o
Add link to training, clarify "Need Help" section 
Made "Need help" consistent with the github template, and added references to the 2.0.4 training.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
14664fc

@tim-o tim-o requested review from nstewart and jseldess Jul 20, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Jul 20, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Jul 20, 2018

This change is Reviewable
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jul 20, 2018

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jul 20, 2018 •
edited

CLA assistant check
All committers have signed the CLA.
@jseldess

jseldess approved these changes Jul 21, 2018 • edited
View changes

LGTM, with a few nits. Thanks, @tim-o!

Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
@tim-o

This comment has been minimized.

Show comment
Hide comment
@tim-o

tim-o Jul 30, 2018

Contributor

bors r+
Contributor

tim-o commented Jul 30, 2018

bors r+
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Jul 30, 2018

🔒 Permission denied

Existing reviewers: click here to make tim-o a reviewer

craig bot commented Jul 30, 2018

🔒 Permission denied

Existing reviewers: click here to make tim-o a reviewer
@jseldess

This comment has been minimized.

Show comment
Hide comment
@jseldess

jseldess Jul 30, 2018

Contributor

@tim-o, can you address my comments before merging?
Contributor

jseldess commented Jul 30, 2018

@tim-o, can you address my comments before merging?
@tim-o

This comment has been minimized.

Show comment
Hide comment
@tim-o

tim-o Jul 30, 2018

Contributor

Of course, I thought that was taken care of - I'm sorry, this is like PR #2, I'm still not super familiar with github.
Contributor

tim-o commented Jul 30, 2018

Of course, I thought that was taken care of - I'm sorry, this is like PR #2, I'm still not super familiar with github.
@tim-o
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
94399e6
@tim-o

This comment has been minimized.

Show comment
Hide comment
@tim-o

tim-o Jul 30, 2018

Contributor

@jseldess - updated
here: 94399e6.
Contributor

tim-o commented Jul 30, 2018

@jseldess - updated
here: 94399e6.
@jseldess

jseldess approved these changes Jul 30, 2018
View changes

LGTM. Thanks, @tim-o.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment