cli: add option to also write client key in PKCS#8 format. #29008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mberhault
force-pushed
the
marc/add_option_to_write_pkcs8_key
branch
from
20f13ed
to
12b83c7
Compare
This is useful for java which does not understand PKCS#1 in PEM format. This does not change the format of the `client.<username>.key` file but writes an additional file named `client.<username>.key.pk8`. Removed `openssl` command to convert key to PKCS#8 in java acceptance test. Release note (cli change): add option to write client key in PKCS#8 format.
mberhault
force-pushed
the
marc/add_option_to_write_pkcs8_key
branch
from
12b83c7
to
768d0dc
Compare
|
Also checked that the PKCS#8 key is accepted by DBeaver:
|
knz
approved these changes
Aug 26, 2018
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 26, 2018
29008: cli: add option to also write client key in PKCS#8 format. r=mberhault a=mberhault This is useful for java which does not understand PKCS#1 in PEM format. This does not change the format of the `client.<username>.key` file but writes an additional file named `client.<username>.key.pk8`. Removed `openssl` command to convert key to PKCS#8 in java acceptance test. Release note (cli change): add option to write client key in PKCS#8 format. Co-authored-by: marc <marc@cockroachlabs.com>
Build succeeded |
|
@mberhault for docs we'll want this in 2.1 too. Can you issue the backport pr? |
|
This is not a bug fix and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for java which does not understand PKCS#1 in PEM format.
This does not change the format of the
client.<username>.keyfile butwrites an additional file named
client.<username>.key.pk8.Removed
opensslcommand to convert key to PKCS#8 in java acceptancetest.
Release note (cli change): add option to write client key in PKCS#8
format.