Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: teamcity-trigger: plumb TC_BUILD_BRANCH env var into builder #30133
Conversation
benesch
requested a review
from
andreimatei
Sep 12, 2018
benesch
requested a review
from cockroachdb/build-prs
as a
code owner
Sep 12, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
andreimatei
Sep 12, 2018
Member
LGTM
…On Wed, Sep 12, 2018 at 2:25 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/30133>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#30133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBcTyU1orhjYpxer7AZ7tQAeLREWodks5uaVGxgaJpZM4Wl7NP>
.
|
LGTM
…On Wed, Sep 12, 2018 at 2:25 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/30133>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#30133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBcTyU1orhjYpxer7AZ7tQAeLREWodks5uaVGxgaJpZM4Wl7NP>
.
|
benesch
merged commit 7637be7
into
cockroachdb:release-2.1
Sep 12, 2018
benesch
deleted the
benesch:backport2.1-30128
branch
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
benesch commentedSep 12, 2018
Backport 1/1 commits from #30128.
/cc @cockroachdb/release
c0bc52b added a dependency on the TC_BUILD_BRANCH env var to the
teamcity-trigger binary, but the wrapping shell script was not
propagating the variable into the builder's env.
Release note: None