New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: teamcity-trigger: plumb TC_BUILD_BRANCH env var into builder #30133

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@benesch
Member

benesch commented Sep 12, 2018

Backport 1/1 commits from #30128.

/cc @cockroachdb/release


c0bc52b added a dependency on the TC_BUILD_BRANCH env var to the
teamcity-trigger binary, but the wrapping shell script was not
propagating the variable into the builder's env.

Release note: None

teamcity-trigger: plumb TC_BUILD_BRANCH env var into builder
c0bc52b added a dependency on the TC_BUILD_BRANCH env var to the
teamcity-trigger binary, but the wrapping shell script was not
propagating the variable into the builder's env.

Release note: None

@benesch benesch requested a review from andreimatei Sep 12, 2018

@benesch benesch requested a review from cockroachdb/build-prs as a code owner Sep 12, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Sep 12, 2018

Member

This change is Reviewable

Member

cockroach-teamcity commented Sep 12, 2018

This change is Reviewable

@andreimatei

This comment has been minimized.

Show comment
Hide comment
@andreimatei

andreimatei Sep 12, 2018

Member
Member

andreimatei commented Sep 12, 2018

@benesch benesch merged commit 7637be7 into cockroachdb:release-2.1 Sep 12, 2018

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@benesch benesch deleted the benesch:backport2.1-30128 branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment