/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: cli: Mark zone command deprecated so it doesn't show up in help text #30808

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Reviewers

@cockroachdb/cli-prs cli-prs

@knz knz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@a-robinson @cockroach-teamcity
@a-robinson
Member

a-robinson commented Oct 1, 2018

Backport 1/1 commits from #30747.

/cc @cockroachdb/release

We had previously marked zone's subcommands as deprecated in
bfc190d, which meant they didn't show
up as available subcommands in the help text of cockroach zone.
However, there was no deprecation message on the zone command itself,
which made the lack of subcommands confusing, and also meant that it
showed up as a command in the help text of the top level cockroach
command. This fixes both issues.

Release note: None
@a-robinson
cli: Mark zone command deprecated so it doesn't show up in help text 
We had previously marked zone's subcommands as deprecated in
bfc190d, which meant they didn't show
up as available subcommands in the help text of `cockroach zone`.
However, there was no deprecation message on the zone command itself,
which made the lack of subcommands confusing, and also meant that it
showed up as a command in the help text of the top level `cockroach`
command. This fixes both issues.

Release note: None
Loading status checks…
743d2dc

@a-robinson a-robinson requested a review from knz Oct 1, 2018

@a-robinson a-robinson requested a review from cockroachdb/cli-prs as a code owner Oct 1, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 1, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 1, 2018

This change is Reviewable

@a-robinson a-robinson merged commit 123b1da into cockroachdb:release-2.1 Oct 1, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment