/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: storage: reduce commit index on quiescence heartbeat, don't drop them #31174

Merged
merged 2 commits into from Oct 11, 2018

Conversation

Reviewers

@tschottdorf tschottdorf

@cockroachdb/core-prs core-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nvanbenschoten @cockroach-teamcity @tschottdorf
@nvanbenschoten
Member

nvanbenschoten commented Oct 10, 2018

Backport 2/2 commits from #31112.

/cc @cockroachdb/release

Informs #30064.

53dc851 introduced logic to drop quiescence heartbeats to Replicas that
are not caught up to the leader. This turns out to be an issue in cases
where:

  • a Range is quiescent
  • a Replica needs a heartbeat to join a Raft group
  • that Replica's node is unable to update its liveness record because
    doing so depends on the Replica joining the Raft group
  • so the Replica never gets any heartbeats and never joins the group

This change adjusts the logic. Instead of dropping these heartbeats, the
leader Replica now sends them, but with a reduced commit index and with
Quiesce equal to false.

nvanbenschoten added some commits Oct 8, 2018

@nvanbenschoten
storage: reduce commit index on quiescence heartbeat, don't drop them 
Informs #30064.

53dc851 introduced logic to drop quiescence heartbeats to Replicas that
are not caught up to the leader. This turns out to be an issue in cases
where:
- a Range is quiescent
- a Replica needs a heartbeat to join a Raft group
- that Replica's node is unable to update its liveness record because
doing so depends on the Replica joining the Raft group
- so the Replica never gets any heartbeats and never joins the group

This change adjusts the logic. Instead of dropping these heartbeats, the
leader Replica now sends them, but with a reduced commit index and with
Quiesce equal to false.

Release note: None
8f55a8e
@nvanbenschoten
storage: remove unreachable code in quiesceAndNotifyLocked 
Release note: None
Loading status checks…
1383d09

@nvanbenschoten nvanbenschoten requested a review from cockroachdb/core-prs as a code owner Oct 10, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 10, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 10, 2018

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit 67c66e2 into cockroachdb:release-2.1 Oct 11, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@nvanbenschoten nvanbenschoten deleted the nvanbenschoten:backport2.1-31112 branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment