Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: distsql: don't use sortTopK when filter is present #31190
Conversation
solongordon
requested a review
from
RaduBerinde
Oct 10, 2018
solongordon
requested review from
cockroachdb/distsql-prs
as
code owners
Oct 10, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
solongordon
merged commit 6680582
into
cockroachdb:release-2.1
Oct 11, 2018
solongordon
deleted the
solongordon:backport2.1-31189
branch
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
solongordon commentedOct 10, 2018
Backport 1/1 commits from #31189.
/cc @cockroachdb/release
The sorter was producing incorrect results when both a limit and a
filter were applied. We can't use sortTopK in this case since some
results may be filtered out in post-processing. Note this scenario is
somewhat rare because typically the filter would be pushed down below
the sort. The issue was observed when selecting from the result of a
SHOW TRACE.
Also removed a bit of dead code.
Fixes #31163
Release note: None