/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: scope table padding under debug index panel section class #31244

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Reviewers

@cockroachdb/admin-ui-prs admin-ui-prs

@couchand couchand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vilterp @cockroach-teamcity @couchand
@vilterp
Contributor

vilterp commented Oct 11, 2018 •
edited

...so it doesn't apply to the jobs page and other pages.

This styling for the debug pages also applied to the jobs page (and the custom graph page), but the debug index and jobs page changes were both on master.

Before After Expectation
Jobs Page image image Fix vertical line that shows up in expanded area
Debug Index image image Same

Release note: None
@vilterp
ui: scope table padding under debug index panel section class 
...so it doesn't apply to the jobs page and other pages.

Release note: None
Loading status checks…
74f9811

@vilterp vilterp requested a review from cockroachdb/admin-ui-prs as a code owner Oct 11, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 11, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 11, 2018

This change is Reviewable

@vilterp vilterp requested a review from couchand Oct 11, 2018

@couchand

This comment has been minimized.

Show comment
Hide comment
@couchand

couchand Oct 11, 2018

Member

LGTM
Member

couchand commented Oct 11, 2018

LGTM
@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Oct 11, 2018

Contributor
Contributor

vilterp commented Oct 11, 2018

craig bot pushed a commit that referenced this pull request Oct 11, 2018

craig[bot] @vilterp
Merge #31244 
31244: ui: scope table padding under debug index panel section class r=vilterp a=vilterp

...so it doesn't apply to the jobs page and other pages.

This styling for the debug pages also applied to the jobs page (and the custom graph page), but the debug index and jobs page changes were both on master.

|             | Before                                                                                                     | After                                                                                                      | Expectation |
|-------------|------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------|-------------|
| Jobs Page   | ![image](https://user-images.githubusercontent.com/7341/46781401-6fd0b900-ccef-11e8-9a8d-a85e36f00cd6.png) | ![image](https://user-images.githubusercontent.com/7341/46781383-50399080-ccef-11e8-9c1a-05af81a026c8.png) | Fix vertical line that shows up in expanded area |
| Debug Index | ![image](https://user-images.githubusercontent.com/7341/46781426-90990e80-ccef-11e8-8f7d-d4d1ebec6fbe.png) | ![image](https://user-images.githubusercontent.com/7341/46781367-41eb7480-ccef-11e8-814f-8897d6734b2f.png) | Same        |

Release note: None

Co-authored-by: Pete Vilter <vilterp@cockroachlabs.com>
Loading status checks…
c4976f9
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 11, 2018

Build failed

craig bot commented Oct 11, 2018

Build failed
@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Oct 11, 2018

Contributor

bors r+
Contributor

vilterp commented Oct 11, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 11, 2018

craig[bot] @vilterp
Merge #31244 
31244: ui: scope table padding under debug index panel section class r=vilterp a=vilterp

...so it doesn't apply to the jobs page and other pages.

This styling for the debug pages also applied to the jobs page (and the custom graph page), but the debug index and jobs page changes were both on master.

|             | Before                                                                                                     | After                                                                                                      | Expectation |
|-------------|------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------|-------------|
| Jobs Page   | ![image](https://user-images.githubusercontent.com/7341/46781401-6fd0b900-ccef-11e8-9a8d-a85e36f00cd6.png) | ![image](https://user-images.githubusercontent.com/7341/46781383-50399080-ccef-11e8-9c1a-05af81a026c8.png) | Fix vertical line that shows up in expanded area |
| Debug Index | ![image](https://user-images.githubusercontent.com/7341/46781426-90990e80-ccef-11e8-8f7d-d4d1ebec6fbe.png) | ![image](https://user-images.githubusercontent.com/7341/46781367-41eb7480-ccef-11e8-814f-8897d6734b2f.png) | Same        |

Release note: None

Co-authored-by: Pete Vilter <vilterp@cockroachlabs.com>
Loading status checks…
a10e709
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 11, 2018

Build succeeded

craig bot commented Oct 11, 2018

Build succeeded

@craig craig bot merged commit 74f9811 into cockroachdb:master Oct 11, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@vilterp vilterp referenced this pull request Oct 11, 2018

Merged

release-2.1: ui: scope table padding under debug index panel section class #31262

@vilterp vilterp deleted the vilterp:fix-table-styling branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment