backport-2.1: storage: avoid spurious nodeDialer logs

[tschottdorf]

Backport 2/2 commits from #31017.

/cc @cockroachdb/release

---

breaker.Success() retrieves its count from an underlying windowed
counter that resets every 10 seconds. As a result, spurious "established
connection to nX" messages would pop up every 10s.

It turns out it's annoyingly difficult to properly gauge whether an
established connection is the first of its kind. In trying to do so, I
became unconvinced that this is even worth it, so I ended up removing
it. I similarly simplified the logging in the unsuccessful case (though
ConsecutiveFailures is actually not a windowed counter and presumably
worked correctly).

I also downgraded the message in the error case to Infof, as it's
expected to see it when nodes are restarted (which is a routine
operation and nothing to worry about). We want to keep the Warning level
for true warnings.

Release note: None

[cockroach-teamcity]

This change is 

[cockroach-teamcity]

This change is 

[petermattis]

LGTM

…

On Thu, Oct 11, 2018 at 4:23 AM cockroach-teamcity ***@***.***> wrote: This change is [image: Reviewable] <https://reviewable.io/reviews/cockroachdb/cockroach/31252> — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#31252 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF6f9z20r4t9W1_TQ16M5Cmj-qHCsR2nks5ujwAcgaJpZM4XXBXv> .

[petermattis]

LGTM

…

On Thu, Oct 11, 2018 at 4:23 AM cockroach-teamcity ***@***.***> wrote: This change is [image: Reviewable] <https://reviewable.io/reviews/cockroachdb/cockroach/31252> — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#31252 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF6f9z20r4t9W1_TQ16M5Cmj-qHCsR2nks5ujwAcgaJpZM4XXBXv> .