New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: ui: scope table padding under debug index panel section class #31262

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@vilterp
Contributor

vilterp commented Oct 11, 2018

Backport 1/1 commits from #31244.

/cc @cockroachdb/release


...so it doesn't apply to the jobs page and other pages.

This styling for the debug pages also applied to the jobs page (and the custom graph page), but I didn't see it until the debug index and jobs page changes were both on master.

Before After Expectation
Jobs Page image image Fix vertical line that shows up in expanded area
Debug Index image image Same

Release note: None

ui: scope table padding under debug index panel section class
...so it doesn't apply to the jobs page and other pages.

Release note: None

@vilterp vilterp requested a review from couchand Oct 11, 2018

@vilterp vilterp requested a review from cockroachdb/admin-ui-prs as a code owner Oct 11, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 11, 2018

Member

This change is Reviewable

Member

cockroach-teamcity commented Oct 11, 2018

This change is Reviewable

@vilterp vilterp merged commit 974ce6a into cockroachdb:release-2.1 Oct 11, 2018

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@vilterp vilterp deleted the vilterp:backport2.1-31244 branch Oct 11, 2018

@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Oct 11, 2018

Contributor

Whoops, got trigger happy and forgot to wait for approval 😅

This straggler is due to some CSS "merge skew"; hope it can get in to 2.1.

Contributor

vilterp commented Oct 11, 2018

Whoops, got trigger happy and forgot to wait for approval 😅

This straggler is due to some CSS "merge skew"; hope it can get in to 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment