Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upstorage: make TestRangeTransferLeaseExpirationBased fail more eargerly #31265
Conversation
m-schneider
requested a review
from
tschottdorf
Oct 11, 2018
m-schneider
requested a review
from cockroachdb/core-prs
as a
code owner
Oct 11, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tschottdorf
Oct 11, 2018
Member
Wait a minute, that failed these tests immediately. Isn't that surprising?
|
Wait a minute, that failed these tests immediately. Isn't that surprising? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
m-schneider
Oct 11, 2018
Contributor
That is surprising, I ran it locally a couple of times and it didn't fail. What do you think?
|
That is surprising, I ran it locally a couple of times and it didn't fail. What do you think? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
m-schneider
Oct 11, 2018
Contributor
Also just ran a regular make stress and it didn't fail for 10 minutes.
|
Also just ran a regular make stress and it didn't fail for 10 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
m-schneider commentedOct 11, 2018
Before we were seeing test flakes from
TestRangeTransferLeaseExpirationBased. The reason for this is that
forceLeaseExtension method in client_replica_test.go was swallowing
every NotLeaseHolderError even though it was only supposed to swallow
them when the leaseholder and the proposed leaseholder where the same
replica.
Now we're only going to swallow the error if the proposed leaseholder
and current leaseholder are the same. This will allow tests that depend
on forceLeaseExtension to fail eargely instead of timing out while
waiting for an error.
Release note: None