/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: sql: make DISTSQL option to EXPLAIN ANALYZE optional #31278

Merged
merged 1 commit into from Oct 14, 2018

Conversation

Reviewers

@jordanlewis jordanlewis

@cockroachdb/sql-language-prs sql-language-prs

@knz knz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@asubiotto @cockroach-teamcity @knz @lhirata @jordanlewis
@asubiotto
Contributor

asubiotto commented Oct 11, 2018

Backport all commits from #31277. There was a merge conflict with the .bnf file because explain_analyze has its own on master. cc @lhirata, does your diagram PR #30036 need to be backported?

Reduce user surprise by not requiring a DISTSQL option in EXPLAIN
ANALYZE.

Release note (sql change): EXPLAIN ANALYZE is now a valid
equivalent of EXPLAIN ANALYZE (DISTSQL)

@asubiotto
sql: make DISTSQL option to EXPLAIN ANALYZE optional 
Reduce user surprise by not requiring a DISTSQL option in EXPLAIN
ANALYZE.

Release note (sql change): EXPLAIN ANALYZE <statement> is now a valid
equivalent of EXPLAIN ANALYZE (DISTSQL) <statement>
Loading status checks…
bee759e

@asubiotto asubiotto requested review from jordanlewis and knz Oct 11, 2018

@asubiotto asubiotto requested a review from cockroachdb/sql-language-prs as a code owner Oct 11, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 11, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 11, 2018

This change is Reviewable
@knz

This comment has been minimized.

Show comment
Hide comment
@knz

knz Oct 11, 2018

Member

LGTM

cc @cockroachdb/release
Member

knz commented Oct 11, 2018

LGTM

cc @cockroachdb/release

@knz knz changed the title from sql: make DISTSQL option to EXPLAIN ANALYZE optional to release-2.1: sql: make DISTSQL option to EXPLAIN ANALYZE optional Oct 11, 2018

@lhirata

This comment has been minimized.

Show comment
Hide comment
@lhirata

lhirata Oct 11, 2018

Collaborator

Yeah, EXPLAIN ANALYZE needs it's own .bnf
Collaborator

lhirata commented Oct 11, 2018

Yeah, EXPLAIN ANALYZE needs it's own .bnf

@asubiotto asubiotto merged commit 3fd21f7 into cockroachdb:release-2.1 Oct 14, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@asubiotto asubiotto deleted the asubiotto:backport2.1-31277 branch Oct 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment