/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: sql: enable client to override index selection for DELETE and UPDATE #31279

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Reviewers

@BramGruneir BramGruneir

@cockroachdb/sql-rest-prs sql-rest-prs

@cockroachdb/sql-language-prs sql-language-prs

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@RaduBerinde RaduBerinde

@awoods187 awoods187

Assignees
No one assigned
Labels
None yet
Projects
  
Finished (milestone r2.1) in SQL Front-end, Lang & Semantics
Milestone
No milestone
3 participants
@knz @cockroach-teamcity @BramGruneir
@knz
Member

knz commented Oct 11, 2018

Backport 1/1 commits from #31012.

/cc @cockroachdb/release

@knz knz requested review from BramGruneir, RaduBerinde and awoods187 Oct 11, 2018

@knz knz requested review from cockroachdb/sql-execution-prs as code owners Oct 11, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 11, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 11, 2018

This change is Reviewable

@knz knz added this to Triage in SQL Front-end, Lang & Semantics via automation Oct 11, 2018

@knz knz moved this from Triage to Current milestone in SQL Front-end, Lang & Semantics Oct 11, 2018

@BramGruneir

BramGruneir approved these changes Oct 11, 2018
View changes

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@knz
sql: enable client to override index selection for DELETE and UPDATE 
Prior to this patch, if the automatic index selection for DELETE or
UPDATE was inadequate, there was no way to override it like it is
possible for SELECT/INSERT/UPSERT.

This patch fixes this by extending and supporting the syntax for
DELETE and UPDATE:

```
DELETE FROM tbl@idx ...
UPDATE tbl@idx SET ...
```

Release note (sql change): it is now possible to force a specific
index for DELETE or UPDATE.
Loading status checks…
9700856

@knz knz merged commit 73e7ce2 into cockroachdb:release-2.1 Oct 12, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@knz knz deleted the knz:backport2.1-31012 branch Oct 12, 2018

@knz knz moved this from Current milestone to Finished (milestone r2.1) in SQL Front-end, Lang & Semantics Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment