/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-2.1: sql: attempt to deflake distsql physical planner tests #31285

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Reviewers

@cockroachdb/sql-planning-prs sql-planning-prs

@cockroachdb/distsql-prs distsql-prs

@andreimatei andreimatei

@asubiotto asubiotto

@RaduBerinde RaduBerinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tschottdorf @cockroach-teamcity @jordanlewis
@tschottdorf
Member

tschottdorf commented Oct 11, 2018 •
edited

Backport 1/1 commits from #31239.

Flaky as hell on release-2.1. Someone please borsmerge this for me with the LGTM.

/cc @cockroachdb/release

Make sure the range cache is populated before verifying things about it.

This seems like a hack, but otherwise I think these will just keep flaking.

Closes #25808.
Closes #31235.

Release note: None
@jordanlewis @tschottdorf
sql: attempt to deflake distsql physical planner tests 
Make sure the range cache is populated before verifying things about it.

Release note: None
Loading status checks…
be62f2d

@tschottdorf tschottdorf requested review from andreimatei, asubiotto and RaduBerinde Oct 11, 2018

@tschottdorf tschottdorf requested review from cockroachdb/distsql-prs as code owners Oct 11, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 11, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 11, 2018

This change is Reviewable
@jordanlewis

This comment has been minimized.

Show comment
Hide comment
@jordanlewis

jordanlewis Oct 11, 2018

Member

LGTM.

bors r+
Member

jordanlewis commented Oct 11, 2018

LGTM.

bors r+

craig bot pushed a commit that referenced this pull request Oct 11, 2018

craig[bot] @jordanlewis
Merge #31285 
31285: backport-2.1: sql: attempt to deflake distsql physical planner tests r=jordanlewis a=tschottdorf

Backport 1/1 commits from #31239.

Flaky as hell on release-2.1. Someone please ~~bors~~merge this for me with the LGTM.

/cc @cockroachdb/release

---

Make sure the range cache is populated before verifying things about it.

This seems like a hack, but otherwise I think these will just keep flaking.

Closes #25808.
Closes #31235.

Release note: None


Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Loading status checks…
00413b0

@jordanlewis jordanlewis merged commit df65f23 into cockroachdb:release-2.1 Oct 11, 2018
2 of 3 checks passed

2 of 3 checks passed

bors Canceled
Details
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment