Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uproachtest: Stop rebalance test as soon as it succeeds #31289
Conversation
a-robinson
requested a review
from
nvanbenschoten
Oct 11, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This change is |
nvanbenschoten
approved these changes
Oct 12, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/cmd/roachtest/rebalance_load.go, line 47 at r1 (raw file):
// usually (but not always fail) with it set to false. rebalanceLoadRun := func( ctx context.Context, t *test, c *cluster, rebalanceMode string, duration time.Duration, concurrency int,
consider changing duration to maxDuration now that this test should finish must faster if everything is good.
pkg/cmd/roachtest/rebalance_load.go, line 81 at r1 (raw file):
duration.String()
nit while you're here: drop the .String()
a-robinson
referenced this pull request
Oct 12, 2018
Closed
roachtest: rebalance-leases-by-load failed #31303
a-robinson
reviewed
Oct 12, 2018
Reviewable status:
pkg/cmd/roachtest/rebalance_load.go, line 47 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
consider changing
durationtomaxDurationnow that this test should finish must faster if everything is good.
Done.
pkg/cmd/roachtest/rebalance_load.go, line 81 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
duration.String()nit while you're here: drop the
.String()
Done.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
bors r+ |
bot
pushed a commit
that referenced
this pull request
Oct 12, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 12, 2018
Build succeeded |
a-robinson commentedOct 11, 2018
Previously it would always run for the entire test duration even after
it achieved success, which was pretty annoying when stressing it.
There may be a more idiomatic way to do this. If so, I'd love to know.
Release note: None