/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv,storage: annotate context cancellation errors #31291

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Reviewers

@nvanbenschoten nvanbenschoten

@a-robinson a-robinson

@cockroachdb/core-prs core-prs

@benesch benesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jordanlewis @cockroach-teamcity @nvanbenschoten @a-robinson
@jordanlewis
Member

jordanlewis commented Oct 11, 2018

Previously, errors retrieved from cancelled context were frequently
passed up the stack without annotation, making it very difficult to
understand later what cancelled a context.

This commit annotates several potential context cancellation errors that
can occur on the synchronous query path with more context (no pun
intended).

Hopefully informs #30886, #31094, #30659, etc.

Release note: None

@jordanlewis jordanlewis requested review from benesch, nvanbenschoten and a-robinson Oct 11, 2018

@jordanlewis jordanlewis requested a review from cockroachdb/core-prs as a code owner Oct 11, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 11, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 11, 2018

This change is Reviewable
@jordanlewis
kv,storage: annotate context cancellation errors 
Previously, errors retrieved from cancelled context were frequently
passed up the stack without annotation, making it very difficult to
understand later what cancelled a context.

This commit annotates several potential context cancellation errors that
can occur on the synchronous query path with more context (no pun
intended).

Release note: None
Verified
This commit was signed with a verified signature.
@jordanlewis jordanlewis Jordan Lewis
GPG key ID: CB92F5D43A08059A Learn about signing commits
Loading status checks…
4290f0d
@a-robinson

a-robinson approved these changes Oct 12, 2018
View changes

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@jordanlewis

This comment has been minimized.

Show comment
Hide comment
@jordanlewis

jordanlewis Oct 12, 2018

Member

TFTR!

bors r+
Member

jordanlewis commented Oct 12, 2018

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Oct 12, 2018

craig[bot] @jordanlewis
Merge #31291 
31291: kv,storage: annotate context cancellation errors r=jordanlewis a=jordanlewis

Previously, errors retrieved from cancelled context were frequently
passed up the stack without annotation, making it very difficult to
understand later what cancelled a context.

This commit annotates several potential context cancellation errors that
can occur on the synchronous query path with more context (no pun
intended).

Hopefully informs #30886, #31094, #30659, etc.

Release note: None

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Loading status checks…
266d2bb
@nvanbenschoten

nvanbenschoten approved these changes Oct 12, 2018
View changes

Nice!

@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 12, 2018

Build succeeded

craig bot commented Oct 12, 2018

Build succeeded

@craig craig bot merged commit 4290f0d into cockroachdb:master Oct 12, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@jordanlewis jordanlewis deleted the jordanlewis:log-cancel branch Oct 12, 2018

This was referenced Oct 15, 2018

Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment