/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: cli: minimize --certs-dir flag description. #31300

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@cockroachdb/cli-prs cli-prs

@mberhault mberhault

@a-robinson a-robinson

@jseldess jseldess

Assignees
No one assigned
Labels
None yet
Projects
  
Done in CLI improvements
Milestone
No milestone
4 participants
@knz @cockroach-teamcity @mberhault @jseldess
@knz
Member

knz commented Oct 12, 2018

Backport 1/1 commits from #29653.

/cc @cockroachdb/release
@mberhault @knz
cli: minimize --certs-dir flag description. 
Certificate setup has expanded to the point where details cannot be
explained sufficiently here. Users should refer to documentation instead.

Release note: none
Loading status checks…
64452a0

@knz knz requested review from mberhault and jseldess Oct 12, 2018

@knz knz requested a review from cockroachdb/cli-prs as a code owner Oct 12, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 12, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 12, 2018

This change is Reviewable
@knz

This comment has been minimized.

Show comment
Hide comment
@knz

knz Oct 15, 2018

Member

👋
Member

knz commented Oct 15, 2018

👋

@knz knz requested a review from a-robinson Oct 15, 2018

@knz knz added this to To do in CLI improvements via automation Oct 15, 2018

@mberhault

This comment has been minimized.

Show comment
Hide comment
@mberhault

mberhault Oct 15, 2018

Contributor

Why backport this?
Contributor

mberhault commented Oct 15, 2018

Why backport this?
@knz

This comment has been minimized.

Show comment
Hide comment
@knz

knz Oct 15, 2018

Member

Because as you point out in the original PR, the help text asks more questions than it answers. We want to proactively lower our support pressure.
Member

knz commented Oct 15, 2018

Because as you point out in the original PR, the help text asks more questions than it answers. We want to proactively lower our support pressure.
@mberhault

This comment has been minimized.

Show comment
Hide comment
@mberhault

mberhault Oct 15, 2018

Contributor

LGTM. Sure, we can hope.
Contributor

mberhault commented Oct 15, 2018

LGTM. Sure, we can hope.
@knz

This comment has been minimized.

Show comment
Hide comment
@knz

knz Oct 15, 2018

Member

My strategy is always optimistic in expectations, pessimistic in achievements. :)
Member

knz commented Oct 15, 2018

My strategy is always optimistic in expectations, pessimistic in achievements. :)

@knz knz merged commit b0b2054 into cockroachdb:release-2.1 Oct 15, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

CLI improvements automation moved this from To do to Done Oct 15, 2018

@knz knz deleted the knz:backport2.1-29653 branch Oct 15, 2018

@jseldess

This comment has been minimized.

Show comment
Hide comment
@jseldess

jseldess Oct 15, 2018

Contributor

LGTM
Contributor

jseldess commented Oct 15, 2018

LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment