/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: importccl: fix the UX of the IMPORT statement #31301

Open
wants to merge 2 commits into
base: release-2.1
from

Conversation

Reviewers

@cockroachdb/sql-rest-prs sql-rest-prs

@cockroachdb/sql-language-prs sql-language-prs

@cockroachdb/sql-bulk-prs sql-bulk-prs

@dt dt

@mjibson mjibson

Assignees
No one assigned
Labels
None yet
Projects
  
Current milestone in SQL Front-end, Lang & Semantics
Milestone
No milestone
2 participants
@knz @cockroach-teamcity
@knz
Member

knz commented Oct 12, 2018

Backport 2/2 commits from #31263.

/cc @cockroachdb/release

knz added some commits Oct 11, 2018

@knz
ccl/storageccl: fix an error message 
Release note: None
2f1b4b7
@knz
sql: clean up the syntax for the IMPORT statement 
Prior to this patch, the IMPORT statement grammar didn't match the
contextual help. The main problem is that the datafile must be
enclosed within parentheses when DATA is specified, and only
optionally when DATA is not specified.

This patch cleans up the situation as follows: the presence of the
parentheses is mandated in contextual help and generated syntax
diagrams for all variants of IMPORT.  This choice is made so that a
future CockroachDB version can add more syntax within the
parentheses without ambiguity.

Release note (sql change, enterprise change): The `IMPORT
format file` syntax is deprecated in favor of `IMPORT format
(<file>)`. Similarly, `IMPORT TABLE ... FROM format file` is
deprecated in favor of `IMPORT TABLE ... FROM format (file)`.
Loading status checks…
67b10de

@knz knz requested review from dt and mjibson Oct 12, 2018

@knz knz added this to Triage in SQL Front-end, Lang & Semantics via automation Oct 12, 2018

@knz knz requested review from cockroachdb/sql-bulk-prs as code owners Oct 12, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 12, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 12, 2018

This change is Reviewable

@knz knz moved this from Triage to Current milestone in SQL Front-end, Lang & Semantics Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment