Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uproachtest, workload: large re-write of interleaved-partition test and workload #31311
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
BramGruneir
requested a review
from
petermattis
Oct 12, 2018
petermattis
requested a review
from
nvanbenschoten
Oct 12, 2018
BramGruneir
requested a review
from
m-schneider
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BramGruneir commentedOct 12, 2018
The interleaved partition workload and test were not performing the correct
operations and there was a good amount of leftover cruft from experiments that
were run. This commit fixes most of those problems.
A non-exhaustive selection of the updates:
leaseholders being locked to the east dc. These should be split evenly between
east and west and now are again.
ids. So all of their operations where essentially noops.
cockroach.
no need for most of them.
well as the worker number. This proves we have a nice spread, as expected.
There's still some more to do here, such as put the full retrieve and update
operations inside a transaction. And try to reduce contention by adding in a
partitioned index for deletes.
All of this work was prompted by #28921, which shows that we had collisions.
Now that the workload is running correctly, if this happens again, we will have
more insight into what's going on.
Release note: None