/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: move TestingKnobs to storagebase #31317

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Reviewers

@tschottdorf tschottdorf

@cockroachdb/core-prs core-prs

@cockroachdb/sql-rest-prs sql-rest-prs

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@cockroachdb/distsql-prs distsql-prs

@cockroachdb/sql-bulk-prs sql-bulk-prs

@benesch benesch

@nvanbenschoten nvanbenschoten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jordanlewis @cockroach-teamcity @tschottdorf
@jordanlewis
Member

jordanlewis commented Oct 12, 2018 •
edited

... to permit users of TestingKnobs not to have to import all of
storage.

Also, delete an unused TestingKnob that accepted Replica as a parameter.

Updates #30001.

Release note: None

@jordanlewis jordanlewis requested review from benesch, tschottdorf and nvanbenschoten Oct 12, 2018

@jordanlewis jordanlewis requested review from cockroachdb/core-prs as code owners Oct 12, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 12, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 12, 2018

This change is Reviewable
@jordanlewis
storage: move storage TestingKnobs to storagebase 
... to permit users of TestingKnobs not to have to import all of
storage.

Also, move batcheval.TestingKnobs to storagebase.BatchEvalTestingKnobs
to avoid the import cycle of storagebase -> batcheval -> storagebase.

Also, delete an unused TestingKnob that accepted Replica as a parameter.

Release note: None
Verified
This commit was signed with a verified signature.
@jordanlewis jordanlewis Jordan Lewis
GPG key ID: CB92F5D43A08059A Learn about signing commits
Loading status checks…
c762c4a
@tschottdorf

tschottdorf approved these changes Oct 12, 2018
View changes

Reviewed 47 of 47 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@jordanlewis

This comment has been minimized.

Show comment
Hide comment
@jordanlewis

jordanlewis Oct 12, 2018

Member

TFTR!

bors r+
Member

jordanlewis commented Oct 12, 2018

TFTR!

bors r+
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 12, 2018

Merge conflict (retrying...)

craig bot commented Oct 12, 2018

Merge conflict (retrying...)

craig bot pushed a commit that referenced this pull request Oct 12, 2018

craig[bot] @jordanlewis
Merge #31317 
31317: storage: move TestingKnobs to storagebase r=jordanlewis a=jordanlewis

... to permit users of TestingKnobs not to have to import all of
storage.

Also, delete an unused TestingKnob that accepted Replica as a parameter.

Updates #30001.

Release note: None

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Loading status checks…
a3ed02a
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 12, 2018

Build succeeded

craig bot commented Oct 12, 2018

Build succeeded

@craig craig bot merged commit c762c4a into cockroachdb:master Oct 12, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@jordanlewis jordanlewis deleted the jordanlewis:move-storage-knobs branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment