/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove dependency on storage.NodeLiveness #31318

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@asubiotto asubiotto

@cockroachdb/sql-planning-prs sql-planning-prs

@cockroachdb/distsql-prs distsql-prs

@dt dt

@solongordon solongordon

@RaduBerinde RaduBerinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jordanlewis @cockroach-teamcity @asubiotto
@jordanlewis
Member

jordanlewis commented Oct 12, 2018

DistSQLPlanner needed to know about it, but just a single IsLive method.
Avoid the dependency by adding a small package-local interface.

Release note: None
@jordanlewis
sql: remove dependency on storage.NodeLiveness 
DistSQLPlanner needed to know about it, but just a single IsLive method.
Avoid the dependency by adding a small package-local interface.

Release note: None
Verified
This commit was signed with a verified signature.
@jordanlewis jordanlewis Jordan Lewis
GPG key ID: CB92F5D43A08059A Learn about signing commits
Loading status checks…
92ea3fa

@jordanlewis jordanlewis requested review from dt and RaduBerinde Oct 12, 2018

@jordanlewis jordanlewis requested review from cockroachdb/distsql-prs as code owners Oct 12, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 12, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 12, 2018

This change is Reviewable

@jordanlewis jordanlewis requested review from solongordon and asubiotto Oct 15, 2018

@jordanlewis

This comment has been minimized.

Show comment
Hide comment
@jordanlewis

jordanlewis Oct 15, 2018

Member

bors r+
Member

jordanlewis commented Oct 15, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @jordanlewis
Merge #31318 
31318: sql: remove dependency on storage.NodeLiveness r=jordanlewis a=jordanlewis

DistSQLPlanner needed to know about it, but just a single IsLive method.
Avoid the dependency by adding a small package-local interface.

Release note: None

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Loading status checks…
3c295ab
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit 92ea3fa into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@jordanlewis jordanlewis deleted the jordanlewis:node-liveness-iface branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment