roachtest: move the logger from cluster to test

[andreimatei]

Before this patch, c.l was essentially a test's logger. But that logger
belongs better on a test than on a cluster, and so I've moved it.
c.l still exists, and it's being set at a high level to t.l. The idea is
that c.l will still be used, at least for the time being, by other
cluster methods, but otherwise tests will switch to using t.l instead of
c.l (this is being done in the next commit).

Release note: None

[cockroach-teamcity]

This change is 

[cockroach-teamcity]

This change is 

[andreimatei]

First commit is elsewhere.

[andreimatei]

First commit is elsewhere.

[benesch]

but I didn't look at the first commit

Reviewed 3 of 3 files at r2, 27 of 27 files at r3, 6 of 6 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale)

---

pkg/cmd/roachtest/cluster.go, line 832 at r3 (raw file):

	// This cloned cluster is not taking ownership. The parent retains it.
	cpy.owned = false
	cpy.destroyed = nil

Is this in the right commit?

---

pkg/cmd/roachtest/test.go, line 919 at r2 (raw file):

			c = c.clone()
		}
		c.setTest(t)

Is this in the right commit?

[andreimatei]

Reviewable status: complete! 1 of 0 LGTMs obtained

---

pkg/cmd/roachtest/cluster.go, line 832 at r3 (raw file):

Previously, benesch (Nikhil Benesch) wrote…

Is this in the right commit?

no, moved to the previous one. thanks

---

pkg/cmd/roachtest/test.go, line 919 at r2 (raw file):

Previously, benesch (Nikhil Benesch) wrote…

Is this in the right commit?

yes. The setTest() call got moved below the clone() call; clone() used to take a test, but no longer.

[benesch]

Reviewed 31 of 31 files at r5, 26 of 26 files at r6, 6 of 6 files at r7.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale)

[andreimatei]

bors r+

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale)

[craig]

Build succeeded

• GitHub CI (Cockroach)

[craig]

Build succeeded

• GitHub CI (Cockroach)