/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Avoid using different qps measurements in StoreRebalancer #31324

Merged
merged 1 commit into from Oct 12, 2018
+13 −8

Conversation

Reviewers

@tschottdorf tschottdorf

@cockroachdb/core-prs core-prs

@nvanbenschoten nvanbenschoten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@a-robinson @cockroach-teamcity @tschottdorf
@a-robinson
Member

a-robinson commented Oct 12, 2018

It's better to use the same measurement for everything, especially
because it's the one that was used to compute the store's total QPS.

Fixes #31303

Release note: None
@a-robinson
storage: Avoid using different qps measurements in StoreRebalancer 
It's better to use the same measurement for everything, especially
because it's the one that was used to compute the store's total QPS.

Fixes #31303

Release note: None
Loading status checks…
af5582c

@a-robinson a-robinson requested a review from nvanbenschoten Oct 12, 2018

@a-robinson a-robinson requested a review from cockroachdb/core-prs as a code owner Oct 12, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 12, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 12, 2018

This change is Reviewable
@a-robinson

This comment has been minimized.

Show comment
Hide comment
@a-robinson

a-robinson Oct 12, 2018

Member

bors r+
Member

a-robinson commented Oct 12, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 12, 2018

craig[bot] @a-robinson
Merge #31324 
31324: storage: Avoid using different qps measurements in StoreRebalancer r=a-robinson a=a-robinson

It's better to use the same measurement for everything, especially
because it's the one that was used to compute the store's total QPS.

Fixes #31303

Release note: None

Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Loading status checks…
6734719
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 12, 2018

Build succeeded

craig bot commented Oct 12, 2018

Build succeeded

@craig craig bot merged commit af5582c into cockroachdb:master Oct 12, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@a-robinson a-robinson referenced this pull request Oct 15, 2018

Merged

release-2.1: storage: Avoid using different qps measurements in StoreRebalancer #31379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment