/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgerror: hint what to do upon encountering unimplemented errors #31333

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@dt dt

@BramGruneir BramGruneir

@cockroachdb/sql-wiring-prs sql-wiring-prs

@cockroachdb/sql-language-prs sql-language-prs

@justinj justinj

Assignees
No one assigned
Labels
None yet
Projects
  
Finished (milestone r2.1) in SQL Front-end, Lang & Semantics
Milestone
No milestone
4 participants
@knz @cockroach-teamcity @dt @BramGruneir
@knz
Member

knz commented Oct 13, 2018

Requested by @awoods187 . Inspired by @tschottdorf

Before:

root@127.0.0.1:28070/defaultdb> select * from information_schema.view_table_usage;
pq: virtual schema table not implemented: information_schema.view_table_usage

After:

root@127.0.0.1:28070/defaultdb> select * from information_schema.view_table_usage;
pq: virtual schema table not implemented: information_schema.view_table_usage
HINT: This feature is not yet implemented in CockroachDB.

Please check https://github.com/cockroachdb/cockroach/issues to check
whether this feature is already tracked. If you cannot find it there,
please report this error with example query at:

    https://github.com/cockroachdb/cockroach/issues/new/choose

If you would rather not post publicly, please contact us directly at:

    support@cockroachlabs.com

The Cockroach Labs team appreciates your feedback.

Release note: None

@knz knz requested a review from dt Oct 13, 2018

@knz knz requested a review from cockroachdb/sql-wiring-prs as a code owner Oct 13, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 13, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 13, 2018

This change is Reviewable

@knz knz added this to Triage in SQL Front-end, Lang & Semantics via automation Oct 13, 2018

@knz knz requested review from justinj and BramGruneir Oct 13, 2018

@knz knz requested a review from cockroachdb/sql-language-prs as a code owner Oct 13, 2018

@knz knz moved this from Triage to Current milestone in SQL Front-end, Lang & Semantics Oct 13, 2018

@knz knz referenced this pull request Oct 15, 2018

Merged

release-2.1: assorted SQL telemetry fixes #31357

@dt

dt approved these changes Oct 15, 2018
View changes

@BramGruneir

BramGruneir approved these changes Oct 15, 2018
View changes

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@knz
pgerror: hint what to do upon encountering unimplemented errors 
Before:

```
root@127.0.0.1:28070/defaultdb> select * from information_schema.view_table_usage;
pq: virtual schema table not implemented: information_schema.view_table_usage
```

After:

```
root@127.0.0.1:28070/defaultdb> select * from information_schema.view_table_usage;
pq: virtual schema table not implemented: information_schema.view_table_usage
HINT: This feature is not yet implemented in CockroachDB.

Please check https://github.com/cockroachdb/cockroach/issues to check
whether this feature is already tracked. If you cannot find it there,
please report this error with example query at:

    https://github.com/cockroachdb/cockroach/issues/new/choose

If you would rather not post publicly, please contact us directly at:

    support@cockroachlabs.com

The Cockroach Labs team appreciates your feedback.
```

Release note: None
Loading status checks…
e62add2
@knz

This comment has been minimized.

Show comment
Hide comment
@knz

knz Oct 15, 2018

Member

thanks!

bors r+
Member

knz commented Oct 15, 2018

thanks!

bors r+

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @knz
Merge #31333 #31356 
31333: pgerror: hint what to do upon encountering unimplemented errors r=knz a=knz

Requested by @awoods187 . Inspired by @tschottdorf 

Before:

```
root@127.0.0.1:28070/defaultdb> select * from information_schema.view_table_usage;
pq: virtual schema table not implemented: information_schema.view_table_usage
```

After:

```
root@127.0.0.1:28070/defaultdb> select * from information_schema.view_table_usage;
pq: virtual schema table not implemented: information_schema.view_table_usage
HINT: This feature is not yet implemented in CockroachDB.

Please check https://github.com/cockroachdb/cockroach/issues to check
whether this feature is already tracked. If you cannot find it there,
please report this error with example query at:

    https://github.com/cockroachdb/cockroach/issues/new/choose

If you would rather not post publicly, please contact us directly at:

    support@cockroachlabs.com

The Cockroach Labs team appreciates your feedback.
```

Release note: None

31356: sql,telemetry: fold unimplemented/error telemetry into feature counters r=knz a=knz

Forked off  #31332.


Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Loading status checks…
b74a347
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit e62add2 into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@knz knz deleted the knz:20181013-enhance-unimp-message branch Oct 15, 2018

@knz knz moved this from Current milestone to Finished (milestone r2.1) in SQL Front-end, Lang & Semantics Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment