Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upsql: expose feature counters via crdb_internal.feature_usage #31334
Conversation
knz
added some commits
Oct 13, 2018
knz
added this to Triage
in SQL Front-end, Lang & Semantics
via automation
Oct 13, 2018
knz
requested a review
from
bobvawter
Oct 13, 2018
knz
requested review from
cockroachdb/core-prs
as
code owners
Oct 13, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
cc @dt |
knz
moved this from Triage
to Current milestone
in SQL Front-end, Lang & Semantics
Oct 13, 2018
bobvawter
approved these changes
Oct 15, 2018
Reviewed 1 of 1 files at r1, 7 of 7 files at r2, 5 of 5 files at r3, 6 of 6 files at r4.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/server/telemetry/features.go, line 96 at r2 (raw file):
// inspection via SQL. They are not quantized! Thus not suitable for // reporting. func GetFeatureCounts() map[string]int32 {
Maybe GetFeatureCountsForDisplay() to make the intended use more obvious if you don't read the doc?
pkg/sql/logictest/testdata/logic_test/crdb_internal, line 140 at r4 (raw file):
query TT colnames SELECT * FROM crdb_internal.feature_usage WHERE feature_name = ''
Might it make sense to select count(usage_count) from feature_usage where feature_name = 'something' yields 1 to ensure that the wiring from telemetry to the virtual table is functioning? I see why you wouldn't want to query for a specific value, but this doesn't verify that the populate struct member is actually populating anything.
knz commentedOct 13, 2018
•
edited
First 3 commits from #31332.
Only last commit in this PR; will rebase when the other is merged.
I found myself using this extensively to work on that other PR and related PRs adding markers for unimplemented features and new feature counts.