/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: fix a comment #31344

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@vilterp vilterp

@petermattis petermattis

@cockroachdb/core-prs core-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tschottdorf @cockroach-teamcity @vilterp @petermattis
@tschottdorf
Member

tschottdorf commented Oct 15, 2018

Passing true here gives results for each NIC. If false were passed,
things would be summed up and a single result returned.

Release note: None
@tschottdorf
status: fix a comment 
Passing `true` here gives results for each NIC. If `false` were passed,
things would be summed up and a single result returned.

Release note: None
Loading status checks…
21f780b

@tschottdorf tschottdorf requested a review from cockroachdb/core-prs as a code owner Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable

@tschottdorf tschottdorf requested a review from vilterp Oct 15, 2018

@petermattis

petermattis approved these changes Oct 15, 2018
View changes

:lgtm:

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@vilterp

vilterp approved these changes Oct 15, 2018
View changes

Thanks for fixing this. Apologies for leaving such a janky comment; meant to track it down myself.

@tschottdorf

This comment has been minimized.

Show comment
Hide comment
@tschottdorf

tschottdorf Oct 15, 2018

Member
Member

tschottdorf commented Oct 15, 2018

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @tschottdorf @benesch
Merge #31344 #31364 
31344: status: fix a comment r=petermattis,vilterp a=tschottdorf

Passing `true` here gives results for each NIC. If `false` were passed,
things would be summed up and a single result returned.

Release note: None

31364: storage: fix typo in comment r=bdarnell a=benesch

Release note: None

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Loading status checks…
0c150f9
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit 21f780b into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment