/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: make heuristic planner bail on HAVING without FROM #31346

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@cockroachdb/sql-rest-prs sql-rest-prs

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@RaduBerinde RaduBerinde

Assignees
No one assigned
Labels
None yet
Projects
  
Finished (milestone r2.1) in SQL Front-end, Lang & Semantics
Milestone
No milestone
2 participants
@knz @cockroach-teamcity
@knz
Member

knz commented Oct 15, 2018

Informs #26349.

The heuristic planner is unable to plan HAVING without FROM
properly. Instead of silently and incorrectly accepting this
construct, this patch makes it error out.

Release note (bug fix): CockroachDB does not any more silently and
incorrectly ignore the HAVING clause on SELECT without FROM.
@knz
sql: make heuristic planner bail on HAVING without FROM 
The heuristic planner is unable to plan HAVING without FROM
properly. Instead of silently and incorrectly accepting this
construct, this patch makes it error out.

Release note (bug fix): CockroachDB does not any more silently and
incorrectly ignore the HAVING clause on SELECT without FROM.
Loading status checks…
586969c

@knz knz added this to Triage in SQL Front-end, Lang & Semantics via automation Oct 15, 2018

@knz knz requested a review from RaduBerinde Oct 15, 2018

@knz knz requested review from cockroachdb/sql-execution-prs as code owners Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable

This was referenced Oct 15, 2018

Merged
Open

@knz knz moved this from Triage to Current milestone in SQL Front-end, Lang & Semantics Oct 15, 2018

@knz

This comment has been minimized.

Show comment
Hide comment
@knz

knz Oct 15, 2018

Member

LGTM from #31347, merging

bors r+
Member

knz commented Oct 15, 2018

LGTM from #31347, merging

bors r+

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @knz
Merge #31346 
31346: sql: make heuristic planner bail on HAVING without FROM r=knz a=knz

Informs #26349.

The heuristic planner is unable to plan HAVING without FROM
properly. Instead of silently and incorrectly accepting this
construct, this patch makes it error out.

Release note (bug fix): CockroachDB does not any more silently and
incorrectly ignore the HAVING clause on SELECT without FROM.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Loading status checks…
addb896

@knz knz moved this from Current milestone to Finished (milestone r2.1) in SQL Front-end, Lang & Semantics Oct 15, 2018

@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit 586969c into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment