Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: sql: make heuristic planner bail on HAVING without FROM #31347
Conversation
knz
requested a review
from
RaduBerinde
Oct 15, 2018
knz
added this to Triage
in SQL Front-end, Lang & Semantics
via automation
Oct 15, 2018
knz
requested review from
cockroachdb/sql-execution-prs
as
code owners
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
knz
moved this from Triage
to Current milestone
in SQL Front-end, Lang & Semantics
Oct 15, 2018
RaduBerinde
approved these changes
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
thanks |
knz
merged commit f4ec893
into
cockroachdb:release-2.1
Oct 15, 2018
knz
deleted the
knz:backport2.1-31346
branch
Oct 15, 2018
knz
referenced this pull request
Oct 15, 2018
Merged
sql: make heuristic planner bail on HAVING without FROM #31346
knz
moved this from Current milestone
to Finished (milestone r2.1)
in SQL Front-end, Lang & Semantics
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
knz commentedOct 15, 2018
Backport 1/1 commits from #31346.
/cc @cockroachdb/release
Informs #26349.
The heuristic planner is unable to plan HAVING without FROM
properly. Instead of silently and incorrectly accepting this
construct, this patch makes it error out.
Release note (bug fix): CockroachDB does not any more silently and
incorrectly ignore the HAVING clause on SELECT without FROM.