/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: sql: bump SET CLUSTER SETTING gossip timeout #31348

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@bdarnell bdarnell

@tschottdorf tschottdorf

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@a-robinson a-robinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nvanbenschoten @cockroach-teamcity @bdarnell @tschottdorf
@nvanbenschoten
Member

nvanbenschoten commented Oct 15, 2018

Backport 1/1 commits from #31194.

/cc @cockroachdb/release

Closes #31193.

This change bumps the timeout that SET CLUSTER SETTING statements
wait for gossip to reflect their expected value. I had seen this
timeout fail when running in highly-distributed, large clusters under
load. 10 seconds seems more reasonable.

Release note: None

@nvanbenschoten nvanbenschoten requested a review from a-robinson Oct 15, 2018

@nvanbenschoten nvanbenschoten requested review from cockroachdb/sql-execution-prs as code owners Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@nvanbenschoten
sql: bump SET CLUSTER SETTING gossip timeout 
This change bumps the timeout that SET CLUSTER SETTING statements
wait for gossip to reflect their expected value. I had seen this
timeout fail when running in highly-distributed clusters under load.
10 seconds seems more reasonable.

Release note: None
Loading status checks…
b26a148

@nvanbenschoten nvanbenschoten merged commit b0ca488 into cockroachdb:release-2.1 Oct 15, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@nvanbenschoten nvanbenschoten deleted the nvanbenschoten:backport2.1-31194 branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment