Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: storage: eagerly queue undersize ranges for merging #31352
Conversation
benesch
requested a review
from
tschottdorf
Oct 15, 2018
benesch
requested a review
from cockroachdb/core-prs
as a
code owner
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tschottdorf
approved these changes
Oct 15, 2018
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
pkg/storage/replica_proposal.go, line 537 at r1 (raw file):
rResult.Delta = enginepb.MVCCStatsDelta{} if r.store.splitQueue != nil && needsSplitBySize { // the boostrap store has a nil split queue
boostrap here and below (but if you bother changing it, let's do it on master and then backport.. so I don't think you should bother)
benesch
reviewed
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/storage/replica_proposal.go, line 537 at r1 (raw file):
Previously, tschottdorf (Tobias Schottdorf) wrote…
boostrap here and below (but if you bother changing it, let's do it on master and then backport.. so I don't think you should bother)
D'oh! Thanks.
benesch
merged commit f0fb532
into
cockroachdb:release-2.1
Oct 15, 2018
benesch
deleted the
benesch:backport2.1-30590
branch
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
benesch commentedOct 15, 2018
Backport 1/1 commits from #30590.
/cc @cockroachdb/release
When processing a write, check if the range has dropped beneath the
minimum size threshold. If it has, check whether the merge queue would
like to process it. This is analogous to our logic for eagerly splitting
oversize ranges.
Fix #29004.
Release note: None
Before (courtesy of @tschottdorf):
After: