Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upsql: deflake TestSchemaChangePurgeFailure #31355
Conversation
eriktrinh
requested a review
from
vivekmenezes
Oct 15, 2018
eriktrinh
requested a review
from cockroachdb/sql-async-prs
as a
code owner
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This change is |
vivekmenezes
requested changes
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/sql/schema_changer_test.go, line 1545 at r1 (raw file):
// Allow schema change purge to attempt backfill. atomic.StoreUint32(&enableAsyncSchemaChanges, 1)
why do we need to turn it on here?
eriktrinh
reviewed
Oct 15, 2018
Reviewable status:
pkg/sql/schema_changer_test.go, line 1545 at r1 (raw file):
Previously, vivekmenezes wrote…
why do we need to turn it on here?
This test tests that an error during the rollback backfill can be recovered via the async schema changer trying to apply mutation again. We allow async schema changes here to allow the backfill from the rollback (which is the dropping of the failed index creation) to occur so we can return an error to test this.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Updated as discussed offline |
vivekmenezes
approved these changes
Oct 15, 2018
Reviewable status:
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
bors r+ |
bot
pushed a commit
that referenced
this pull request
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 15, 2018
Build succeeded |
eriktrinh commentedOct 15, 2018
Initially disable fast exec async schema changes in the test until the
error is seen and index drop is queued.
Fixes #31296.
Release note: None