Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upworkload: add pgx-based SQLRunner, use it in KV #31358
Conversation
RaduBerinde
requested review from
mjibson,
danhhz and
nvanbenschoten
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RaduBerinde
Oct 15, 2018
Member
Full benchmark results (including a comparison with a gosql version of SQLRunner): https://docs.google.com/spreadsheets/d/1I028xgdHM9nqydMG3KblfzvZlXGfLRBXrC3xeqiilG8/edit?usp=sharing
|
Full benchmark results (including a comparison with a gosql version of SQLRunner): https://docs.google.com/spreadsheets/d/1I028xgdHM9nqydMG3KblfzvZlXGfLRBXrC3xeqiilG8/edit?usp=sharing |
RaduBerinde
referenced this pull request
Oct 15, 2018
Closed
workload: add SQLRunner, use it in KV #31159
danhhz
reviewed
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/workload/pgx_helpers.go, line 83 at r1 (raw file):
// Get returns one of the pools, in round-robin manner. func (m *MultiConnPool) Get() *pgx.ConnPool {
Have you thought about how this will play with the partition affinity in tpcc? Keep the existing logic but with one MultiConnPool per url perhaps?
RaduBerinde
reviewed
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/workload/pgx_helpers.go, line 83 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
Have you thought about how this will play with the partition affinity in tpcc? Keep the existing logic but with one MultiConnPool per url perhaps?
Yeah, that should work fine.
danhhz
reviewed
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
nvanbenschoten
approved these changes
Oct 15, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 2 stale)
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
bors r+ |
bot
pushed a commit
that referenced
this pull request
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 15, 2018
Build succeeded |
RaduBerinde commentedOct 15, 2018
SQLRunner is a common facility for issuing SQL queries through
pgx.It supports multiple issuing methods, specified by the
--methodflag:
reused.
is equivalent to preparing and executing each statement
separately).
before it is issued.
KV is switched to use the new runner. The default
preparemethodshould be similar to the old code (except that we go through
pgx).Benchmark numbers (ops/s for kv80, single node GCE worker):
Release note: None