Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: distsql: fix nil pointer in sort benchmarks #31360
Conversation
solongordon
requested review from
jordanlewis and
asubiotto
Oct 15, 2018
solongordon
requested review from
cockroachdb/distsql-prs
as
code owners
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
solongordon
Oct 15, 2018
Contributor
Backporting this in case we ever want to compare these benchmark stats between 2.1 and 2.2. Should be a risk-free backport since it only touches benchmark code.
|
Backporting this in case we ever want to compare these benchmark stats between 2.1 and 2.2. Should be a risk-free backport since it only touches benchmark code. |
solongordon
merged commit 21dd8ed
into
cockroachdb:release-2.1
Oct 15, 2018
solongordon
deleted the
solongordon:backport2.1-31208
branch
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
solongordon commentedOct 15, 2018
Backport 1/1 commits from #31208.
/cc @cockroachdb/release
Sorter benchmarks were failing with nil pointer errors due to a missing
disk monitor.
Release note: None